Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752047AbbHQVMU (ORCPT ); Mon, 17 Aug 2015 17:12:20 -0400 Received: from www.linutronix.de ([62.245.132.108]:54359 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbbHQVMQ (ORCPT ); Mon, 17 Aug 2015 17:12:16 -0400 Date: Mon, 17 Aug 2015 23:11:41 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Alexander Holler , Mark Rustad , Alex Deucher , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7 In-Reply-To: <1439108128-18441-1-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1439108128-18441-1-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 48 On Sun, 9 Aug 2015, Jiang Liu wrote: > Alex Deucher, Mark Rustad and Alexander Holler reported a regression > with the latest v4.2-rc4 kernel, which breaks some SATA controllers. > With multi-MSI capable SATA controllers, only the first port works, > all other ports times out when executing SATA commands. This regression > bisects to 52f518a3a7c2 ("x86/MSI: Use hierarchical irqdomains to manage > MSI interrupts"), but it's not the root cause, it just triggers a bug > caused by b5dc8e6c21e7 ("x86/irq: Use hierarchical irqdomain to manage > CPU interrupt vectors"). > > With this patch applied, the affected SATA controllers work as expected. This changelog including the subject line is horrible. 1) The subject line should describe the change in a short and precise form x86/irq: Fix a regression caused by commit b5dc8e6c21e7 fits the short category, but completely fails to be precise. It's not interesting for the subject line which commit caused the problem and whether it's a regression or not. We want a to see a proper description of the change itself. 2) The changelog should describe the bug itself. ... but it's not the root cause, it just triggers a bug caused by b5dc8e6c21e7 ("x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors"). does not tell what the actual bug in the code is. 3) The changelog should describe the solution. With this patch applied, the affected SATA controllers work as expected. is describing the desired effect of the change, but not the change itself. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/