Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752035AbbHQWgE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Aug 2015 18:36:04 -0400
Received: from casper.infradead.org ([85.118.1.10]:40531 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750921AbbHQWgD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Aug 2015 18:36:03 -0400
Subject: Re: linux-next: Tree for Aug 17 (staging/hfi1)
To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
References: <20150817205533.72ebb3fb@canb.auug.org.au>
Cc: linux-kernel@vger.kernel.org,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>
From: Randy Dunlap <rdunlap@infradead.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <55D261CA.2070802@infradead.org>
Date: Mon, 17 Aug 2015 15:35:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150817205533.72ebb3fb@canb.auug.org.au>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2701
Lines: 57

On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20150813:
> 


Several items:

A:  these and other similar errors:

In file included from ../drivers/staging/hfi1/chip.c:61:0:
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_LINKVERB’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_CNTR’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_CNTR’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_DC8051’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_DC8051’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_RCVCTRL’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_RCVCTRL’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_TID’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_TID’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^

B:  When CONFIG_PCI is not enabled, lots of these errors:

In file included from ../drivers/staging/hfi1/chip.c:60:0:
../drivers/staging/hfi1/hfi.h:508:20: error: field ‘msix’ has incomplete type
  struct msix_entry msix;
                   ^

../drivers/staging/hfi1/chip.c: In function ‘disable_intx’:
../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function ‘pci_intx’ [-Werror=implicit-function-declaration]
  pci_intx(pdev, 0);
  ^

so the driver should depend on PCI or maybe even PCI_MSI.

C.  Please provide some contact info, e.g. in a TODO file or the MAINTAINERS file.


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/