Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbbHQXqg (ORCPT ); Mon, 17 Aug 2015 19:46:36 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32395 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbHQXqf (ORCPT ); Mon, 17 Aug 2015 19:46:35 -0400 Date: Tue, 18 Aug 2015 02:46:28 +0300 From: Dan Carpenter To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte Cc: Greg Kroah-Hartman , Rachel Kim , Dean Lee , Chris Park , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Johnny Kim , linux-kernel@vger.kernel.org, Arend van Spriel Subject: Re: [PATCHv3] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Message-ID: <20150817234628.GK5558@mwanda> References: <55D238D4.20800@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 18 On Mon, Aug 17, 2015 at 07:12:47PM -0400, Rapha?l Beamonte wrote: > The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't > take care of possible memory leaks and subsequent bugs when it was failing > after succeeding some allocations. This patch corrects this behavior. > > Signed-off-by: Rapha?l Beamonte > --- Yes. This looks good now. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/