Date: Mon, 17 Aug 2015 18:58:16 -0500
From: Felipe Balbi <balbi@ti.com>
To: Mark Brown <broonie@kernel.org>
CC: Peter Chen <peter.chen@freescale.com>,
        Baolin Wang <baolin.wang@linaro.org>, <balbi@ti.com>,
        <linus.walleij@linaro.org>, <linux-kernel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <sojka@merica.cz>,
        <stern@rowland.harvard.edu>, <r.baldyga@samsung.com>,
        <yoshihiro.shimoda.uh@renesas.com>, <linux-usb@vger.kernel.org>,
        <device-mainlining@lists.linuxfoundation.org>, <sre@kernel.org>,
        <dbaryshkov@gmail.com>, <dwmw2@infradead.org>, <sameo@linux.intel.com>,
        <lee.jones@linaro.org>, <patches@opensource.wolfsonmicro.com>,
        <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current
 limit management
Message-ID: <20150817235816.GA5621@saruman.tx.rr.com>
Reply-To: <balbi@ti.com>
References: <cover.1439519412.git.baolin.wang@linaro.org>
 <f3bfd04bc157e97e2d0632b7ed2452f366f66488.1439519413.git.baolin.wang@linaro.org>
 <20150817010707.GC1864@shlinux2>
 <20150817172623.GO10748@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G"
Content-Disposition: inline
In-Reply-To: <20150817172623.GO10748@sirena.org.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2277
Lines: 67

--k1lZvvs/B4yU6o8G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 17, 2015 at 10:26:23AM -0700, Mark Brown wrote:
> On Mon, Aug 17, 2015 at 09:07:08AM +0800, Peter Chen wrote:
> > On Fri, Aug 14, 2015 at 05:47:46PM +0800, Baolin Wang wrote:
>=20
> > > +	1500,
> > > +	1800,
> > > +	550,
> > > +};
>=20
> > Why 550 is the last, but not 1800?
>=20
> You'd have to ask the hardware engineers who designed the chip.  I
> suspect it's because 550 was added at a late stage in the design process
> but I'm basically just guessing there.
>=20
> > >   *******************************************************************=
**/
> > > @@ -606,8 +646,31 @@ static int wm831x_power_probe(struct platform_de=
vice *pdev)
> > >  		}
> > >  	}
>=20
> > > +	if (wm831x_pdata && wm831x_pdata->usb_gadget) {
>=20
> > Where the wm831x_pdata->usb_gadget is initialized?
>=20
> It's platform data, it will be initialised by whatever registers the
> platform data.

passing pointers through pdata ?

--=20
balbi

--k1lZvvs/B4yU6o8G
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJV0nUYAAoJEIaOsuA1yqREUNgP/iumke66F36gyG04af1/s+VM
lIKszsGlpunYdaWKTJxriGPzpZRXCzn0J43bpcQgYrPvLQYItjeROXlPgrCTh0Th
PUum7E/lNd2vx8vHv4HNLwFxc7bJF945AUpnqXqS0MLQgWppkJ4DNRLMMRK5px2v
Q8MhaZoHOgWCp+OpQZIw5UOCq6QzQv7TZk7iDCQv+JJYwBgJuDWpmNZEQ/LerhMi
2wEWJsaBq2guvAO1eCSN+CSnjz3Uz7+B2BEGdi4L8GuWR/dzHwJJQ+/ZDgHXI1ee
alKVqPCOx2ozxLXcEnsRkcfReKgg6+4Uj+gC873aEMrI/gleCpzlfIWslc2SRW8w
QC/L/XyHNUtWe4FQ6XXgoBuZCaQUvYPH49tsJHoLUGscV17UVjk50inWNJEvdidk
MXObg2+du06Zmtz11IabQmGznDV0nCVX4Jl1RfqjFFYLLll+5i3hKeD9N4TorVim
UTX2uIvhWsnAvOknnakAoX2d8/zHK/qtx8TpUAWQDo2unJDEqBlyjXmCoJA/Nth+
LqrvDD8dH0n+CJvThJhTYHcPoCUK/S6T4abaiyvwgE/IsCeeXa2jn73OJ/sT12/Q
BDSoegtDLMDTV8oASE106FO8W9VcN6ooDa4CCmF1C72ixTysX369zEejlvbuJm1u
mn1VRLAcRslQdMigrN1u
=I1On
-----END PGP SIGNATURE-----

--k1lZvvs/B4yU6o8G--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/