Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbbHRCeJ (ORCPT ); Mon, 17 Aug 2015 22:34:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbbHRCeH convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2015 22:34:07 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings From: "Yan, Zheng" In-Reply-To: <1876245679.2939973.1439773537944.JavaMail.zimbra@redhat.com> Date: Tue, 18 Aug 2015 10:34:00 +0800 Cc: linux-kernel , sage@redhat.com Content-Transfer-Encoding: 8BIT Message-Id: <30CDC3A0-82AB-4B87-BFF9-D8D645334830@redhat.com> References: <1876245679.2939973.1439773537944.JavaMail.zimbra@redhat.com> To: Brad Hubbard Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 33 > On Aug 17, 2015, at 09:05, Brad Hubbard wrote: > > ceph: remove redundant test of head->safe and silence static analysis warnings > > Signed-off-by: Brad Hubbard > --- > fs/ceph/mds_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index 6aa07af..6e196ee 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) > mutex_unlock(&mdsc->mutex); > goto out; > } > - if (req->r_got_safe && !head->safe) { > + if (req->r_got_safe) { > pr_warn("got unsafe after safe on %llu from mds%d\n", > tid, mds); > mutex_unlock(&mdsc->mutex); > -- added to our testing branch, Thanks Yan, Zheng-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/