Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbbHRCpi (ORCPT ); Mon, 17 Aug 2015 22:45:38 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36709 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbbHRCpg (ORCPT ); Mon, 17 Aug 2015 22:45:36 -0400 MIME-Version: 1.0 In-Reply-To: <20150817204751.GD10748@sirena.org.uk> References: <20150813072920.GA17181@localhost> <20150817204751.GD10748@sirena.org.uk> Date: Tue, 18 Aug 2015 08:15:35 +0530 Message-ID: Subject: Re: [PATCH] ASoC: tegra: Convert to managed resources From: Vaishali Thakkar To: Mark Brown Cc: Alexandre Courbot , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Stephen Warren , Thierry Reding , Wolfram Sang , "alsa-devel@alsa-project.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 30 On Tue, Aug 18, 2015 at 2:17 AM, Mark Brown wrote: > On Mon, Aug 17, 2015 at 03:02:29PM +0530, Vaishali Thakkar wrote: > >> I think you are right. I missed that. But now thing is , this patch is already >> applied here: >> https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=topic/tegra > >> I am not sure if now I can change version 2 with the changes you suggested >> or not. Although I will not be able to test it after changing 'goto >> err_suspend' >> as I don't have hardware but may be someone else can test it. > > You can send an incremental update on top of what's there, or it may be > more sensible to just discard the change entirely. I suspect we're safe > with either PM vs component ordering though since we should support !PM > configurations anyway. I think yes may be code was good before this. But devm_clk_put part should work fine as call of it is before PM stuff. So, can I send a patch reverting the change of component part or do you want me to send a patch reverting whole change? -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/