Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752121AbbHRDTB (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Aug 2015 23:19:01 -0400
Received: from ozlabs.org ([103.22.144.67]:33522 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750875AbbHRDTA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Aug 2015 23:19:00 -0400
Message-ID: <1439867938.1763.6.camel@ellerman.id.au>
Subject: Re: [PATCH RESEND] powerpc/numa: initialize distance lookup table
 from drconf path
From: Michael Ellerman <mpe@ellerman.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, anton@samba.org,
        linux-kernel@vger.kernel.org, bharata@linux.vnet.ibm.com
Date: Tue, 18 Aug 2015 13:18:58 +1000
In-Reply-To: <87si7q2lq2.fsf@linux.vnet.ibm.com>
References: <1435815541-11860-1-git-send-email-nikunj@linux.vnet.ibm.com>
	 <87si7q2lq2.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1945
Lines: 55

On Tue, 2015-08-11 at 15:25 +0530, Nikunj A Dadhania wrote:
> Hi Michael,
> 
> Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> writes:
> > In some situations, a NUMA guest that supports
> > ibm,dynamic-memory-reconfiguration node will end up having flat NUMA
> > distances between nodes. This is because of two problems in the
> > current code.
> >
> > 1) Different representations of associativity lists.
> >
> >    There is an assumption about the associativity list in
> >    initialize_distance_lookup_table(). Associativity list has two forms:
> >
> >    a) [cpu,memory]@x/ibm,associativity has following
> >       format:
> >            <N> <N integers>
> >
> >    b) ibm,dynamic-reconfiguration-memory/ibm,associativity-lookup-arrays
> >
> >            <M> <N> <M associativity lists each having N integers>
> >            M = the number of associativity lists
> >            N = the number of entries per associativity list
> >
> >    Fix initialize_distance_lookup_table() so that it does not assume
> >    "case a". And update the caller to skip the length field before
> >    sending the associativity list.
> >
> > 2) Distance table not getting updated from drconf path.
> >
> >    Node distance table will not get initialized in certain cases as
> >    ibm,dynamic-reconfiguration-memory path does not initialize the
> >    lookup table.
> >
> >    Call initialize_distance_lookup_table() from drconf path with
> >    appropriate associativity list.
> >
> > Reported-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> > Acked-by: Anton Blanchard <anton@samba.org>
> 
> Have you pulled this?

Nope.

Will add it now.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/