Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbbHRE2N (ORCPT ); Tue, 18 Aug 2015 00:28:13 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:34335 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbHRE2M (ORCPT ); Tue, 18 Aug 2015 00:28:12 -0400 Date: Tue, 18 Aug 2015 01:24:26 -0300 From: Ezequiel Garcia To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Message-ID: <20150818042426.GA27858@laptop> References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2123 Lines: 64 On 11 Aug 09:57 PM, Robert Jarzmik wrote: > Add verbose debug for register accesses. This enables easier debugging > by following where and how hardware is stimulated, and how it answers. > I really don't see why we want this patch. It's probably an useful hack to use in some cases, but can't see why we would want it in mainline. Feel free to prove me wrong. > Signed-off-by: Robert Jarzmik > --- > drivers/mtd/nand/pxa3xx_nand.c | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 1259cc558ce9..ed44bddcc43f 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -127,11 +127,23 @@ > #define EXT_CMD_TYPE_MONO 0 /* Monolithic read/write */ > > /* macros for registers read/write */ > -#define nand_writel(info, off, val) \ > - writel_relaxed((val), (info)->mmio_base + (off)) > - > -#define nand_readl(info, off) \ > - readl_relaxed((info)->mmio_base + (off)) > +#define nand_writel(info, off, val) \ > + do { \ > + dev_vdbg(&info->pdev->dev, \ > + "%s():%d nand_writel(0x%x, %s)\n", \ > + __func__, __LINE__, (val), #off); \ > + writel_relaxed((val), (info)->mmio_base + (off)); \ > + } while (0) > + > +#define nand_readl(info, off) \ > + ({ \ > + unsigned int _v; \ > + _v = readl_relaxed((info)->mmio_base + (off)); \ > + dev_vdbg(&info->pdev->dev, \ > + "%s():%d nand_readl(%s): 0x%x\n", \ > + __func__, __LINE__, #off, _v); \ > + _v; \ > + }) > > /* error code and state */ > enum { > -- > 2.1.4 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/