Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbbHRF1x (ORCPT ); Tue, 18 Aug 2015 01:27:53 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:35754 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbbHRF1v convert rfc822-to-8bit (ORCPT ); Tue, 18 Aug 2015 01:27:51 -0400 MIME-Version: 1.0 In-Reply-To: <20150818042417.GA2941@sudip-pc> References: <20150817195542.GB6591@kroah.com> <20150818042417.GA2941@sudip-pc> From: =?UTF-8?Q?Rapha=C3=ABl_Beamonte?= Date: Tue, 18 Aug 2015 01:27:31 -0400 X-Google-Sender-Auth: rdeUHSTcSZucPt-lLsKN-D089qM Message-ID: Subject: Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Rachel Kim , Dean Lee , Chris Park , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Johnny Kim , linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 23 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee : >> + netdev_err("[Sendconfigpkt]Get Timed out\n"); > This will not compile. you can not just replace printk with > netdev_*, you need to mention a net_device. You're right! I'm making a lot of mistakes. It seems I called the make command in the wrong git tree... Thanks for catching that, and taking time to review! I just saw there isn't any netdev_debug available. Do you know the reason for that? Is there a replacement besides pr_debug? Also, it seems that in all the functions where it's another netdev that's available that I could use, I don't have access to the net_device struct. Is there a general way to get that device information? I saw an old lkml post talking about dev_*() functions to do that? Would you have some hint on the matter? Thanks a lot! Raphaël -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/