Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752229AbbHRFin (ORCPT <rfc822;w@1wt.eu>);
	Tue, 18 Aug 2015 01:38:43 -0400
Received: from mail-yk0-f172.google.com ([209.85.160.172]:34104 "EHLO
	mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752137AbbHRFil convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 18 Aug 2015 01:38:41 -0400
MIME-Version: 1.0
In-Reply-To: <20150818050222.GB2941@sudip-pc>
References: <cover.1439688440.git.raphael.beamonte@gmail.com>
 <b9959e7d7c80c82527bf6acf788a3998fc7931f9.1439688440.git.raphael.beamonte@gmail.com>
 <20150818050222.GB2941@sudip-pc>
From: =?UTF-8?Q?Rapha=C3=ABl_Beamonte?= <raphael.beamonte@gmail.com>
Date: Tue, 18 Aug 2015 01:38:21 -0400
X-Google-Sender-Auth: a3IHpYzuaNREIzEBLHBCLoQFKCI
Message-ID: <CAE_Gge0hoBesmz2m3wzkUOx5k+pWzmZVuFiXs2OiXaS+Op1wnw@mail.gmail.com>
Subject: Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent
 spacing code style error
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Greg Donald <gdonald@gmail.com>,
        Cristina Opriceana <cristina.opriceana@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 813
Lines: 21

2015-08-18 1:02 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> since you are modifying these lines for consistent spacing, it will be
> better to have:
> (priv->ShortRetryLimit << TCR_SRL_OFFSET) |       // Short retry limit
<snip>
> This should be:
> priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >> 8;

Are you talking about spacing around the << and >> ?
If so, shouldn't that last line be:
priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID >> 1)) >> 8;

And should I thus apply that to the whole file?

Thanks!
Raphaël
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/