Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbbHRGDK (ORCPT ); Tue, 18 Aug 2015 02:03:10 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:33641 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbbHRGDJ convert rfc822-to-8bit (ORCPT ); Tue, 18 Aug 2015 02:03:09 -0400 MIME-Version: 1.0 In-Reply-To: <20150818054415.GF2941@sudip-pc> References: <20150818050222.GB2941@sudip-pc> <20150818054415.GF2941@sudip-pc> From: =?UTF-8?Q?Rapha=C3=ABl_Beamonte?= Date: Tue, 18 Aug 2015 02:02:49 -0400 X-Google-Sender-Auth: T2_4bY9yOBAkwGsa3b1A6VYkFDo Message-ID: Subject: Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Donald , Cristina Opriceana Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 30 2015-08-18 1:44 GMT-04:00 Sudip Mukherjee : > I think that will be better, since you are sending the patch for > consistent spacing. Actually, going through the bunch of patches, it seems that the whitespace neatening one is taking care of that. That one patch was mostly about taking care of the checkpatch "consistent spacing" warning. Two solutions here: (1) I can merge both patches and make a general whitespace neatening one, taking care of that too. (2) I can clarify the commit messages of each patches to explain the aim of each. Of course, in (1) too I'd take care of explaining the whole point of the commit. What do you think would be the best approach at this point? > And some of your patches are not having any commit message. Greg will > not accept such patches. So while you are sending take care of that > also. Ok! Thanks again! Raphaƫl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/