Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbbHRGFZ (ORCPT ); Tue, 18 Aug 2015 02:05:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34795 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbbHRGFY (ORCPT ); Tue, 18 Aug 2015 02:05:24 -0400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: rt2x00: adjust EEPROM_SIZE for rt2500usb From: Kalle Valo In-Reply-To: <1439245553-2840-1-git-send-email-adrien+dev@schischi.me> To: Adrien Schildknecht Cc: sgruszka@redhat.com, helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Adrien Schildknecht Message-Id: <20150818060523.707B1140394@smtp.codeaurora.org> Date: Tue, 18 Aug 2015 06:05:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 22 > rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET) > but only 0x6a bytes has been allocated and read from the eeprom. > > This lead to out-of-bound accesses and invalid values for > EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. > > Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields. > > Tested with a rt2570 device. > > Signed-off-by: Adrien Schildknecht > Acked-by: Stanislaw Gruszka Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/