Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbbHRGgc (ORCPT ); Tue, 18 Aug 2015 02:36:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:37177 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbbHRGgb (ORCPT ); Tue, 18 Aug 2015 02:36:31 -0400 From: Johannes Thumshirn To: Sebastian Herbszt Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Colin King Subject: Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2() References: <1439809382-32419-1-git-send-email-jthumshirn@suse.de> <20150817232634.00006d80@localhost> Date: Tue, 18 Aug 2015 08:36:29 +0200 In-Reply-To: <20150817232634.00006d80@localhost> (Sebastian Herbszt's message of "Mon, 17 Aug 2015 23:26:34 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 31 Sebastian Herbszt writes: > Johannes Thumshirn wrote: >> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution >> continues normally and mp gets kfree()d. >> >> If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the >> error label where lpfc_mbuf_free() is called with mp->virt and mp->phys as >> function arguments. This is the use after free. Following the use after free mp >> gets kfree()d again which is a double free. > > A similar patch was posted by Colin Ian King on 2015-07-31 [1]. > > [1] http://marc.info/?l=linux-scsi&m=143835937206204&w=2 OK, Is it already in James' tree (haven't checked)? The problematic code was merged for 4.2-rc1 so if the fix (Collin's or mine I don't care) could go in while we're still in the rc phase, we could avoid all that stable circus. Thanks for digging this out. Byte, Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/