Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbbHRI5v (ORCPT ); Tue, 18 Aug 2015 04:57:51 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47760 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbHRI5t (ORCPT ); Tue, 18 Aug 2015 04:57:49 -0400 Date: Tue, 18 Aug 2015 11:57:31 +0300 From: Dan Carpenter To: Ronit Halder Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: fbtft: Fix iomem dereference Message-ID: <20150818085731.GL5558@mwanda> References: <1439880417-15675-1-git-send-email-ronit.crj@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439880417-15675-1-git-send-email-ronit.crj@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 18 On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "cast removes address space of expression" by using ioread16 > function insted of directly dereferencing I/O memory. > > Signed-off-by: Ronit halder Are these really iomem pointers? A lot of drivers use a fake screen_base which is just a buffer of normal memory. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/