Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbHRI6S (ORCPT ); Tue, 18 Aug 2015 04:58:18 -0400 Received: from www.linutronix.de ([62.245.132.108]:56091 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbbHRI6Q (ORCPT ); Tue, 18 Aug 2015 04:58:16 -0400 Date: Tue, 18 Aug 2015 10:57:50 +0200 (CEST) From: Thomas Gleixner To: Shaohua Li cc: John Stultz , lkml , Prarit Bhargava , Richard Cochran , Daniel Lezcano , Ingo Molnar Subject: Re: [PATCH 8/9] clocksource: Improve unstable clocksource detection In-Reply-To: <20150818025704.GA1129225@devbig257.prn2.facebook.com> Message-ID: References: <1439844063-7957-1-git-send-email-john.stultz@linaro.org> <1439844063-7957-9-git-send-email-john.stultz@linaro.org> <20150818025704.GA1129225@devbig257.prn2.facebook.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 38 On Mon, 17 Aug 2015, Shaohua Li wrote: > On Mon, Aug 17, 2015 at 03:17:28PM -0700, John Stultz wrote: > > That said, I agree the "should"s and other vague qualifiers in the > > commit description you point out should have more specifics to back > > things up. And I'm fine delaying this (and the follow-on) patch until > > those details are provided. > > It's not something I guess. We do see the issue from time to time. The > IPMI driver accesses some IO ports in softirq and hog cpu for a very > long time, then the watchdog alert. You still fail to provide proper numbers. 'very long time' does not qualify as an argument at all. > The false alert on the other hand has very worse effect. It forces > to use HPET as clocksource, which has very big performance > penality. We can't even manually switch back to TSC as current > interface doesn't allow us to do it, then we can only reboot the > system. I agree the driver should be fixed, but the watchdog has > false alert, we definitively should fix it. I tend to disagree. The watchdog has constraints and the driver is violating these constraints, so the first thing which wants to be addressed is the driver itself. The behaviour of the watchdog in the case of constraint violations is definitely suboptimal and can lead to false positives. I'm not against making that more robust, but I'm not accepting your 'watchdog is broken' argumentation at all. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/