Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752568AbbHRI75 (ORCPT ); Tue, 18 Aug 2015 04:59:57 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59410 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751778AbbHRI7z (ORCPT ); Tue, 18 Aug 2015 04:59:55 -0400 Date: Tue, 18 Aug 2015 10:59:53 +0200 From: Antoine Tenart To: Robert Jarzmik Cc: Antoine Tenart , Ezequiel Garcia , Brian Norris , David Woodhouse , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Message-ID: <20150818085953.GB3261@kwain> References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <1439323034-8820-3-git-send-email-robert.jarzmik@free.fr> <20150816213655.GA4585@laptop.cereza> <87oai6an6j.fsf@belgarion.home> <87k2stagad.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k2stagad.fsf@belgarion.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 53 Hi, On Mon, Aug 17, 2015 at 09:03:38PM +0200, Robert Jarzmik wrote: > Ezequiel Garcia writes: > > > On 16 August 2015 at 19:22, Robert Jarzmik wrote: > >> Ezequiel Garcia writes: > >> > >>> On 11 Aug 09:57 PM, Robert Jarzmik wrote: > >>>> The cases of READID detection are broken on pxa3xx. The reason is that > >>>> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we > >>>> always have : > >>>> - info->use_dma = 0 (regardless of dma support yet) > >>>> - info->chunk_size = 0 (not yet detected) > >>>> > >>>> The READID issued by pxa3xx_nand_scan() will therefore end up in > >>>> handle_data_pio(), and do_bytes will be 0, leading to not reading the > >>>> nand id, and blocking detection. > >>>> > >>>> This doesn't happen if "keep_config" is used, which is probably the most > >>>> tested case. > >>>> > >>>> Signed-off-by: Robert Jarzmik > >>>> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O > >>>> support") > >>> > >>> To be fair, Antoine submitted this a while ago: > >>> > >>> http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html > >>> > >>> Not sure which one takes precedence in such a case (and yours > >>> has a proper Fixes tag). > >> His has precedence. How is it that a fix patch is not yet merge since April ? > >> Is it because it's part of a still in review serie ? > > Antoine, could you resubmit this single patch with this as trailer please : > Acked-by: Robert Jarzmik > Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O > support") I just resend it. Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/