Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbbHRKzu (ORCPT ); Tue, 18 Aug 2015 06:55:50 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35476 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbHRKzt (ORCPT ); Tue, 18 Aug 2015 06:55:49 -0400 Date: Tue, 18 Aug 2015 12:55:46 +0200 From: Michal Hocko To: LKML Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Johannes Weiner , Tetsuo Handa , Dave Chinner , "Theodore Ts'o" , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara Subject: Re: [RFC -v2 5/8] ext4: Do not fail journal due to block allocator Message-ID: <20150818105545.GH5033@dhcp22.suse.cz> References: <1438768284-30927-1-git-send-email-mhocko@kernel.org> <1438768284-30927-6-git-send-email-mhocko@kernel.org> <20150818103903.GD5033@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150818103903.GD5033@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 24 On Tue 18-08-15 12:39:03, Michal Hocko wrote: [...] > @@ -992,9 +992,8 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb, > block = group * 2; > pnum = block / blocks_per_page; > poff = block % blocks_per_page; > - page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS); > - if (!page) > - return -ENOMEM; > + page = find_or_create_page(inode->i_mapping, pnum, > + GFP_NOFS|__GFP_NOFAIL); Scratch this one. find_or_create_page is allowed to return NULL. The patch is bogus. I was overly eager to turn all places to not check the return value. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/