Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbbHRNiV (ORCPT ); Tue, 18 Aug 2015 09:38:21 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37418 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbbHRNiT (ORCPT ); Tue, 18 Aug 2015 09:38:19 -0400 MIME-Version: 1.0 In-Reply-To: <20150818085731.GL5558@mwanda> References: <1439880417-15675-1-git-send-email-ronit.crj@gmail.com> <20150818085731.GL5558@mwanda> Message-ID: From: Ronit Halder To: Dan Carpenter Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] Staging: fbtft: Fix iomem dereference Date: Tue, 18 Aug 2015 19:08:09 +0530 X-Mailer: Evolution 3.10.4-0ubuntu2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 27 Yes, it is not I/O memory address. I was wrong on that. But it makes sparse happy. Is here any side effect of using ioread16() ? regards, ronit On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter wrote: > On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >> "cast removes address space of expression" by using ioread16 >> function insted of directly dereferencing I/O memory. >> >> Signed-off-by: Ronit halder > > Are these really iomem pointers? A lot of drivers use a fake > screen_base which is just a buffer of normal memory. > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/