Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315AbbHROUm (ORCPT ); Tue, 18 Aug 2015 10:20:42 -0400 Received: from mail-vk0-f41.google.com ([209.85.213.41]:35450 "EHLO mail-vk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbHROUj (ORCPT ); Tue, 18 Aug 2015 10:20:39 -0400 MIME-Version: 1.0 In-Reply-To: <1439720057-9186-9-git-send-email-ygardi@codeaurora.org> References: <1439720057-9186-1-git-send-email-ygardi@codeaurora.org> <1439720057-9186-9-git-send-email-ygardi@codeaurora.org> Date: Tue, 18 Aug 2015 23:15:30 +0900 Message-ID: Subject: Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations From: Akinobu Mita To: Yaniv Gardi Cc: robherring2@gmail.com, Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 25 Hi Yaniv, 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : > @@ -708,17 +713,18 @@ static inline u32 ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba) > return ufshcd_readl(hba, REG_UFS_VERSION); > } > > -static inline void ufshcd_vops_clk_scale_notify(struct ufs_hba *hba) > +static inline int ufshcd_vops_clk_scale_notify(struct ufs_hba *hba, > + bool up, bool status) > { > if (hba->vops && hba->vops->clk_scale_notify) > - return hba->vops->clk_scale_notify(hba); > + return hba->vops->clk_scale_notify(hba, up, status); > + return 0; > } The third argument of clk_scale_notify() vops is PRE_CHANGE or POST_CHANGE. So should it also be converted from bool to enum ufs_notify_change_status like other vops does? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/