Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbbHROYl (ORCPT ); Tue, 18 Aug 2015 10:24:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:64160 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbHROYk (ORCPT ); Tue, 18 Aug 2015 10:24:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,701,1432623600"; d="scan'208";a="627712149" From: "Marciniszyn, Mike" To: Randy Dunlap , Stephen Rothwell , "linux-next@vger.kernel.org" , Doug Ledford CC: "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" Subject: RE: linux-next: Tree for Aug 17 (staging/hfi1) Thread-Topic: linux-next: Tree for Aug 17 (staging/hfi1) Thread-Index: AQHQ2T0a9o2c9LAMR0GTpeZdpy+Q9p4Rw1xg Date: Tue, 18 Aug 2015 14:24:32 +0000 Message-ID: <32E1700B9017364D9B60AED9960492BC257995D2@fmsmsx120.amr.corp.intel.com> References: <20150817205533.72ebb3fb@canb.auug.org.au> <55D261CA.2070802@infradead.org> In-Reply-To: <55D261CA.2070802@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7IEOk7O016193 Content-Length: 2131 Lines: 50 > A: these and other similar errors: > > In file included from ../drivers/staging/hfi1/chip.c:61:0: > ../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’: > ../drivers/staging/hfi1/trace.h:1357:20: error: function > ‘__hfi1_trace_LINKVERB’ can never be inlined because it uses variable > argument lists static inline void __hfi1_trace_##fn(const char *func, char > *fmt, ...) \ > This was corrected with https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27221.html, which I think Doug has picked up. Doug, Randy, Stephen how do we want to handle fixing drivers/staging/hfi1 via the staging list vs. the linux-rdma list? > B: When CONFIG_PCI is not enabled, lots of these errors: > The driver used to get a gift from the drivers/infiniband/hw/Kconfig, which has the required PCI dependency. The infiniband dependency is also similarly missing and was resolved via the following temporary patch: https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg26989.html This one also needs to be similarly added for that 0-day build issue. I have submitted to both lists https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27299.html assuming the above one as a dependency. > In file included from ../drivers/staging/hfi1/chip.c:60:0: > ../drivers/staging/hfi1/hfi.h:508:20: error: field ‘msix’ has incomplete > type > struct msix_entry msix; > ^ > > ../drivers/staging/hfi1/chip.c: In function ‘disable_intx’: > ../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function > ‘pci_intx’ [-Werror=implicit-function-declaration] > pci_intx(pdev, 0); > ^ > > so the driver should depend on PCI or maybe even PCI_MSI. > > C. Please provide some contact info, e.g. in a TODO file or the MAINTAINERS > file. > I have submitted https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27298.html to both lists to add a maintainer. Mike ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?