Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbbHRPdi (ORCPT ); Tue, 18 Aug 2015 11:33:38 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36967 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752889AbbHRPdh (ORCPT ); Tue, 18 Aug 2015 11:33:37 -0400 Date: Tue, 18 Aug 2015 17:33:34 +0200 From: Maxime Ripard To: Hans de Goede Cc: Timo Sigurdsson , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, wens@csie.org Subject: Re: [linux-sunxi] Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi Message-ID: <20150818153334.GG2547@lukather> References: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> <20150803094723.GD2564@lukather> <55BF688D.5010905@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BzCohdixPhurzSK4" Content-Disposition: inline In-Reply-To: <55BF688D.5010905@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4024 Lines: 136 --BzCohdixPhurzSK4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 03, 2015 at 03:11:41PM +0200, Hans de Goede wrote: > Hi, >=20 > On 03-08-15 11:47, Maxime Ripard wrote: > >On Sun, Aug 02, 2015 at 06:18:25PM +0200, Timo Sigurdsson wrote: > >>sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 P= MU > >>driver, so add them to allow for voltage-scaling with cpufreq-dt. > >> > >>Signed-off-by: Timo Sigurdsson > >>--- > >>Changes since v1 (RFC): > >> > >>- Dropped the changes to the cpufreq operating points and renamed the p= atch > >>accordingly > >>- Limited the CPU voltage range so it doesn't exceed the SOC specificat= ions > >>--- > >> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 35 +++++++++++++++++++++++= +++++---- > >> 1 file changed, 31 insertions(+), 4 deletions(-) > >> > >>diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/d= ts/sun7i-a20-bananapi.dts > >>index 9f7b472..74382f3 100644 > >>--- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > >>+++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > >>@@ -92,6 +92,10 @@ > >> status =3D "okay"; > >> }; > >> > >>+&cpu0 { > >>+ cpu-supply =3D <®_dcdc2>; > >>+}; > >>+ > >> &ehci0 { > >> status =3D "okay"; > >> }; > >>@@ -119,13 +123,9 @@ > >> status =3D "okay"; > >> > >> axp209: pmic@34 { > >>- compatible =3D "x-powers,axp209"; > >> reg =3D <0x34>; > >> interrupt-parent =3D <&nmi_intc>; > >> interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > >>- > >>- interrupt-controller; > >>- #interrupt-cells =3D <1>; > >> }; > >> }; > >> > >>@@ -182,6 +182,33 @@ > >> }; > >> }; > >> > >>+#include "axp209.dtsi" > >>+ > >>+®_dcdc2 { > >>+ regulator-always-on; > >>+ regulator-min-microvolt =3D <1000000>; > >>+ regulator-max-microvolt =3D <1400000>; > >>+ regulator-name =3D "vdd-cpu"; > >>+}; > >>+ > >>+®_dcdc3 { > >>+ regulator-always-on; > >>+ regulator-min-microvolt =3D <1000000>; > >>+ regulator-max-microvolt =3D <1400000>; > >>+ regulator-name =3D "vdd-int-dll"; > >>+}; > >>+ > >>+®_ldo1 { > >>+ regulator-name =3D "vdd-rtc"; > >>+}; > >>+ > >>+®_ldo2 { > >>+ regulator-always-on; > >>+ regulator-min-microvolt =3D <3000000>; > >>+ regulator-max-microvolt =3D <3000000>; > >>+ regulator-name =3D "avcc"; > >>+}; > > > >What regulator provides the 3.3V regulator used in the rest of this DT > >then (MMC, GMAC) ? >=20 > A separate fixed regulator, like most (all?) other axp209 using boards, > e.g. the cubieboard has a TCS4199 regulator for this, and the banana > boards use a XL8206/UP1746 for this, according to the schematics I > have. Ack. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --BzCohdixPhurzSK4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV01BOAAoJEBx+YmzsjxAgSW4P/i4wyqa55a4e7g2qA/RlCwFW G/cYylwt+DyBSOH878z1cL35oRH5fbBzV+vNy48dtGFQTBDjda1CttUWpsWuW7vG zmgZdh3Re3I8xE6fads2kbxmbIfeW2lNC/9JGWmNv9L4cZnQDhfqMj+OVV7ARw7j wtHsqvsS27ZVD/h15rrGnief1TLsg/OcR4tDSXxxClXNuwjtcGnaA04Bgr5H8VpK 8H9KYR8ZOCJWjwRaRWQcgmbhTkIbaqRplgIsMZXkWuMQU82Zo+pfkzkXDR4zCd3A M/cEiy3yD4VSQoIVIj/Bpe2zTUPUBWRlWqH9ffXuYDmgjitljK9s9RJe1bjTSkuL 9tSEOvYJ2eQMZocf/mVFtBZIYv0j0j0ZVAhCyDzgbyIl6zs3WLLfgyzKK4DZtMQ1 YQFUqr7I2++bE+xxtnifdjQQB5a9GFc8I53tB/iDjogF40oP8sKnF3rNce8fnITe H+4N37277vByxK+AT3i5qJ52iG5C5v/Yy45ptPjeVk2ZYu5fMq7ST1cqYuD+MBie YihFfFYxgGCvAb/zpXXfRbvXyRwB3RFjeqtWGRl7d/WeSuPqO3yHDtD29f23qZWJ Wu7ySt1ka5U6766fuT1rD49eziMsw9wtIkWtN8R1Sejb8SZz+ncnCsCECG7JTVIJ WyjCbXEV14hYojGasy5W =IhZ9 -----END PGP SIGNATURE----- --BzCohdixPhurzSK4-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/