Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbbHRQJI (ORCPT ); Tue, 18 Aug 2015 12:09:08 -0400 Received: from [216.4.250.2] ([216.4.250.2]:60692 "EHLO p2012.superclick.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbHRQJG (ORCPT ); Tue, 18 Aug 2015 12:09:06 -0400 Date: Tue, 18 Aug 2015 09:07:49 -0700 From: Mark Brown To: Jonas Gorski Cc: Leilk Liu , Mark Rutland , Matthias Brugger , Sascha Hauer , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and remove redundant clock Message-ID: <20150818160749.GJ10748@sirena.org.uk> References: <1439895231-17778-1-git-send-email-leilk.liu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vRyMahX6VF+pdQvX" Content-Disposition: inline In-Reply-To: X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1699 Lines: 41 --vRyMahX6VF+pdQvX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 18, 2015 at 02:19:54PM +0200, Jonas Gorski wrote: > The usual philosophy is to have one change per patch, so this might be > better as three patches. But this is Mark's call. Since the driver > isn't yet in Linus' tree, it might be a-ok to mix style improvements > and actual fixes, but as soon as it landed in Linus' tree you need to > keep them separate, so fixes can be easily backported. This isn't just about making the fixes easy to backport, it's also about making the patch reviewable and understandable. When many changes are included in one patch it makes it harder to tell what any one part of the patch is intended to do. As Jonas has identified several bugs you'll need to resend anyway, please split the series up. --vRyMahX6VF+pdQvX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV01hRAAoJECTWi3JdVIfQz6cH/3DNlew2DvZ1/HnluOiIknH0 ivLgO+u6Dkj7OaYiR/pbG1fFiElH/C+iVV7aveAfaZPnhXZhipoPYnt6JXS8G5v9 Df1oDua6shcoiC+KooEaZ9FnWHCDjQxiZCILYhP+ROVXogsQ0kSOMFLBFYVgEf2N e+ReqHuG5kncZ4l5U/ClnSbjaEPJXg/0+g2ZU5VSM/Rm2MWA62yvF5CaLgm5jVCQ MfhIU+mnqRAc/TYV4CRysPO1KY9gdSTVMpePxnXq+XXZ1sGiVeL3TM40YPSiJFGu 5m9yMnd2Nn0DV5Ij6VsuyVFfqHElgmiPKsjftvmukyejAuVPywFJTdRU0k8XCHQ= =iN/G -----END PGP SIGNATURE----- --vRyMahX6VF+pdQvX-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/