Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbbHRQN1 (ORCPT ); Tue, 18 Aug 2015 12:13:27 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21770 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753598AbbHRQNY (ORCPT ); Tue, 18 Aug 2015 12:13:24 -0400 Subject: Re: [PATCH 0/7] gpio: omap: fixes and improvements To: Grygorii Strashko , Linus Walleij , Alexandre Courbot , ssantosh@kernel.org, Kevin Hilman , tony@atomide.com References: <1439896258-26449-1-git-send-email-grygorii.strashko@ti.com> Cc: Javier Martinez Canillas , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: santosh shilimkar Organization: Oracle Corporation Message-ID: <55D35989.9030508@oracle.com> Date: Tue, 18 Aug 2015 09:12:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1439896258-26449-1-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2203 Lines: 48 On 8/18/2015 4:10 AM, Grygorii Strashko wrote: > Hi, > > This patch series contains set of trivial fixes and improvements, and also > patches which fixes wrong APIs usage in atomic context as for -RT as for > non-RT kernel. The final goal of this series is to make TI OMAP GPIO > driver compatible with -RT kernel as much as possible. > > Patch 1-4: trivial fixes and improvements > Patch 5: fixes wrong CLK clk_prepare/unprepare APIs usage in atomic contexet > Patch 6(rfc): required to be compatible with -RT kernel, because PM runtime > can't be used in atimic context on -RT. > Patch 7(rfc): This patch converts TI OMAP GPIO driver to use generic irq > handler instead of chained IRQ handler. This way OMAP GPIO driver will be > compatible with RT kernel where it will be forced thread IRQ handler > while in non-RT kernel it still will be executed in HW IRQ context. > > Based on > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git > branch: devel > commit: 929550b gpio: mxc: fix section mismatch warning > > Boot, basic gpio functionality tested on: > dra7-evm, BeagleBone(white), am43xx-gpevm, am437x-sk > Manually tested on dra7-evm including suspend/resume and wakeup. > > Grygorii Strashko (7): > gpio: omap: remove wrong irq_domain_remove usage in probe > gpio: omap: switch to use platform_get_irq > gpio: omap: fix omap2_set_gpio_debounce > gpio: omap: protect regs access in omap_gpio_irq_handler > gpio: omap: fix clk_prepare/unprepare usage > gpio: omap: move pm runtime in irq_chip.irq_bus_lock/sync_unlock > gpio: omap: convert to use generic irq handler > > drivers/gpio/gpio-omap.c | 146 +++++++++++++++++++++++++++-------------------- > 1 file changed, 85 insertions(+), 61 deletions(-) > Patch 1 to 5 looks fine to me. You can have that one as a series. Am not convinced about 6 and 7. Will look at it again in detail. For 1 to 5, Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/