Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbbHRTRQ (ORCPT ); Tue, 18 Aug 2015 15:17:16 -0400 Received: from gloria.sntech.de ([95.129.55.99]:48287 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbbHRTRO (ORCPT ); Tue, 18 Aug 2015 15:17:14 -0400 From: Heiko Stuebner To: Brian Norris Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Norris , devicetree@vger.kernel.org, Alexandru M Stan , Douglas Anderson Subject: Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties Date: Tue, 18 Aug 2015 21:17:06 +0200 Message-ID: <51457775.D3ds00ymOJ@phil> User-Agent: KMail/4.14.1 (Linux/4.1.0-1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1439923455-109818-2-git-send-email-briannorris@chromium.org> References: <1439923455-109818-1-git-send-email-briannorris@chromium.org> <1439923455-109818-2-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 55 Hi Brian, thanks for catching these oversights, but see below Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris: > This DTS file was submitted with non-upstream bindings. I happened > across this while reviewing the jaq DTS. > > Signed-off-by: Brian Norris > Cc: Alexandru M Stan > Cc: Douglas Anderson > --- > Tested on jaq, not minnie > > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts > b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index > 0e30bd6bf92b..6f619c154dc6 100644 > --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts > +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts > @@ -128,12 +128,16 @@ > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > regulator-name = "vcc33_touch"; > - regulator-suspend-mem-disabled; > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > }; > > vcc5v_touch: SWITCH_REG2 { > regulator-name = "vcc5v_touch"; > - regulator-suspend-mem-disabled; > + regulator-state-mem { > + regulator-on-in-suspend; > + }; wouldn't regulator-suspend-mem-disabled translate to regulator-off-in-suspend? At least looks like it according to https://lkml.org/lkml/2013/7/25/592 Heiko > }; > }; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/