Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbbHRVTV (ORCPT ); Tue, 18 Aug 2015 17:19:21 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:37509 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbbHRVTT (ORCPT ); Tue, 18 Aug 2015 17:19:19 -0400 MIME-Version: 1.0 In-Reply-To: <20150817225041.GN26431@google.com> References: <1438039809-24957-1-git-send-email-yinghai@kernel.org> <1438039809-24957-2-git-send-email-yinghai@kernel.org> <20150817225041.GN26431@google.com> Date: Tue, 18 Aug 2015 14:19:18 -0700 X-Google-Sender-Auth: k75O8JYxfpyjU_9er902njEzKt4 Message-ID: Subject: Re: [PATCH v3 01/51] PCI: Cleanup res_to_dev_res() printout for addon resources From: Yinghai Lu To: Bjorn Helgaas Cc: David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang , Andrew Morton , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2085 Lines: 49 On Mon, Aug 17, 2015 at 3:50 PM, Bjorn Helgaas wrote: > On Mon, Jul 27, 2015 at 04:29:19PM -0700, Yinghai Lu wrote: >> Now get_res_add_size and get_res_add_align all have same printout >> from res_to_dev_res(), and it is confusing. >> >> Move out debug messages printout from res_to_dev_res(), >> and later we will reuse res_to_dev_res() in other functions. >> >> Signed-off-by: Yinghai Lu >> --- >> drivers/pci/setup-bus.c | 34 ++++++++++++++++++++-------------- >> 1 file changed, 20 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c >> index 508cc56..f0fa705 100644 >> --- a/drivers/pci/setup-bus.c >> +++ b/drivers/pci/setup-bus.c >> @@ -104,19 +104,9 @@ static struct pci_dev_resource *res_to_dev_res(struct list_head *head, >> { >> struct pci_dev_resource *dev_res; >> >> - list_for_each_entry(dev_res, head, list) { >> - if (dev_res->res == res) { >> - int idx = res - &dev_res->dev->resource[0]; >> - >> - dev_printk(KERN_DEBUG, &dev_res->dev->dev, >> - "res[%d]=%pR res_to_dev_res add_size %llx min_align %llx\n", >> - idx, dev_res->res, >> - (unsigned long long)dev_res->add_size, >> - (unsigned long long)dev_res->min_align); >> -... >> + >> + dev_printk(KERN_DEBUG, &dev_res->dev->dev, >> + "BAR %d: %pR get_res_add_align min_align %llx\n", >> + (int)(res - &dev_res->dev->resource[0]), >> + res, (unsigned long long)dev_res->min_align); > > Please use %#llx so we have a "0x" prefix like other hex numbers. > ok. Later i'd like to just kill those debug printout if all get settled after this patchset. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/