Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbbHRVps (ORCPT ); Tue, 18 Aug 2015 17:45:48 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:33372 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555AbbHRVpr (ORCPT ); Tue, 18 Aug 2015 17:45:47 -0400 MIME-Version: 1.0 In-Reply-To: References: <1438039809-24957-1-git-send-email-yinghai@kernel.org> <1438039809-24957-10-git-send-email-yinghai@kernel.org> <20150817235307.GR26431@google.com> Date: Tue, 18 Aug 2015 14:45:46 -0700 X-Google-Sender-Auth: Ol5EB05u3xbRHjiA09MQiEpXmno Message-ID: Subject: Re: [PATCH v3 09/51] PCI: Rename pdev_sort_resources to pdev_check_resources From: Yinghai Lu To: Bjorn Helgaas Cc: David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang , Andrew Morton , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 17 On Tue, Aug 18, 2015 at 2:36 PM, Yinghai Lu wrote: > On Mon, Aug 17, 2015 at 4:53 PM, Bjorn Helgaas wrote: >> On Mon, Jul 27, 2015 at 04:29:27PM -0700, Yinghai Lu wrote: >>> We don't do sorting in those functions anymore, so change "sort" to "check" >>> instead. >> >> What *do* we do in those functions? "Check" doesn't tell me anything. > > Put all children devices' resources that need to assign in one list, and also > do some sanitary checking like if align is good or not. or change to dev_assign_resources_prepare() ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/