Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987AbbHRWQd (ORCPT ); Tue, 18 Aug 2015 18:16:33 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37056 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbbHRWQb (ORCPT ); Tue, 18 Aug 2015 18:16:31 -0400 Date: Wed, 19 Aug 2015 00:16:26 +0200 From: Frederic Weisbecker To: Andy Lutomirski Cc: X86 ML , Sasha Levin , Brian Gerst , Denys Vlasenko , linux-kernel@vger.kernel.org, Oleg Nesterov , Borislav Petkov Subject: Re: [PATCH] x86/entry/64: Context-track syscalls before enabling interrupts Message-ID: <20150818221623.GA12858@lerouge> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 18 On Tue, Aug 18, 2015 at 12:11:59PM -0700, Andy Lutomirski wrote: > This fixes a couple minor holes if we took an IRQ very early in syscall > processing: > > - We could enter the IRQ with CONTEXT_USER. Everything worked (RCU > was fine), but we could warn if all the debugging options were > set. So this is fixing issues after your changes that call user_exit() from IRQs, right? But the IRQs aren't supposed to call user_exit(), they have their own hooks. That's where the real issue is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/