Date: Tue, 18 Aug 2015 15:38:18 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Seth Jennings <sjennings@variantweb.net>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [PATCH 1/2] zpool: define and use max type length
Message-Id: <20150818153818.cab58a99f60113c2aca2f006@linux-foundation.org>
In-Reply-To: <1439928361-31294-1-git-send-email-ddstreet@ieee.org>
References: <1439928361-31294-1-git-send-email-ddstreet@ieee.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1477
Lines: 40

On Tue, 18 Aug 2015 16:06:00 -0400 Dan Streetman <ddstreet@ieee.org> wrote:

> Add ZPOOL_MAX_TYPE_NAME define, and change zpool_driver *type field to
> type[ZPOOL_MAX_TYPE_NAME].  Remove redundant type field from struct zpool
> and use zpool->driver->type instead.
> 
> The define will be used by zswap for its zpool param type name length.
> 

Patchset is fugly.  All this putzing around with fixed-length strings,
worrying about overflow and is-it-null-terminated-or-isnt-it.  Shudder.

It's much better to use variable-length strings everywhere.  We're not
operating in contexts which can't use kmalloc, we're not
performance-intensive and these strings aren't being written to
fixed-size fields on disk or anything.  Why do we need any fixed-length
strings?

IOW, why not just replace that alloca with a kstrdup()?

> --- a/include/linux/zpool.h
> +++ b/include/linux/zpool.h
>
> ...
>
> @@ -79,7 +77,7 @@ static struct zpool_driver *zpool_get_driver(char *type)
>  
>  	spin_lock(&drivers_lock);
>  	list_for_each_entry(driver, &drivers_head, list) {
> -		if (!strcmp(driver->type, type)) {
> +		if (!strncmp(driver->type, type, ZPOOL_MAX_TYPE_NAME)) {

Why strncmp?  Please tell me these strings are always null-terminated.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/