Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbbHRXDu (ORCPT ); Tue, 18 Aug 2015 19:03:50 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:36298 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbbHRXDr (ORCPT ); Tue, 18 Aug 2015 19:03:47 -0400 MIME-Version: 1.0 In-Reply-To: <1439890818-22138-1-git-send-email-lyz@rock-chips.com> References: <1439890818-22138-1-git-send-email-lyz@rock-chips.com> Date: Tue, 18 Aug 2015 16:03:46 -0700 X-Google-Sender-Auth: Ps5Y0jsVyvh4xWyO3MzJ2TlQ6jg Message-ID: Subject: Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams() From: Doug Anderson To: Yunzhi Li Cc: Julius Werner , Tao Huang , Eddie Cai , Lin Huang , John Youn , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 30 lyz, On Tue, Aug 18, 2015 at 2:40 AM, Yunzhi Li wrote: > We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should > be called before dwc2_get_hwparams() to reset core registers to > default value. Without this the FIFO setting might be incorrect > because calculating FIFO size need power-on value of > GRXFSIZ/GNPTXFSIZ/HPTXFSIZ registers. > > This patch could avoid warnning massage like in rk3288 platform: > [ 2.074764] dwc2 ff580000.usb: 256 invalid for > host_perio_tx_fifo_size. Check HW configuration. > > Signed-off-by: Yunzhi Li > > --- > > drivers/usb/dwc2/core.c | 2 +- > drivers/usb/dwc2/core.h | 1 + > drivers/usb/dwc2/platform.c | 6 ++++++ > 3 files changed, 8 insertions(+), 1 deletion(-) This seems reasonable to me. Reviewed-by: Douglas Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/