Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbbHSAcX (ORCPT ); Tue, 18 Aug 2015 20:32:23 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:34881 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbbHSAcV (ORCPT ); Tue, 18 Aug 2015 20:32:21 -0400 Date: Tue, 18 Aug 2015 17:32:17 -0700 From: Brian Norris To: Vaishali Thakkar Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: denali: Use module_pci_driver Message-ID: <20150819003217.GQ60523@google.com> References: <20150707072345.GA20060@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150707072345.GA20060@vaishali-Ideapad-Z570> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 42 On Tue, Jul 07, 2015 at 12:53:45PM +0530, Vaishali Thakkar wrote: > Use module_pci_driver for drivers whose init and exit functions > only register and unregister, respectively. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @a@ > identifier f, x; > @@ > -static f(...) { return pci_register_driver(&x); } > > @b depends on a@ > identifier e, a.x; > @@ > -static e(...) { pci_unregister_driver(&x); } > > @c depends on a && b@ > identifier a.f; > declarer name module_init; > @@ > -module_init(f); > > @d depends on a && b && c@ > identifier b.e, a.x; > declarer name module_exit; > declarer name module_pci_driver; > @@ > -module_exit(e); > +module_pci_driver(x); > > Signed-off-by: Vaishali Thakkar It seems I got 3 independent versions of the same patch... I pushed the most recent one, then noticed this one. Thanks anyway. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/