Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbHSB3h (ORCPT ); Tue, 18 Aug 2015 21:29:37 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:35004 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbbHSB3e (ORCPT ); Tue, 18 Aug 2015 21:29:34 -0400 MIME-Version: 1.0 In-Reply-To: <20150818160414.GB3551@kroah.com> References: <6a4d68543dcffe76993dc70d94a0a04617ef2257.1439866451.git.baolin.wang@linaro.org> <20150818160414.GB3551@kroah.com> Date: Wed, 19 Aug 2015 09:29:33 +0800 Message-ID: Subject: Re: [PATCH v3 1/3] gadget: Support for the usb charger framework From: Baolin Wang To: Greg KH Cc: Felipe Balbi , Mark Brown , Linus Walleij , LKML , Peter Chen , sojka@merica.cz, Alan Stern , r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org, sre@kernel.org, Dmitry Eremin-Solenikov , David Woodhouse , sameo@linux.intel.com, Lee Jones , patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 46 On 19 August 2015 at 00:04, Greg KH wrote: > On Tue, Aug 18, 2015 at 07:14:19PM +0800, Baolin Wang wrote: >> The usb charger framework is based on usb gadget, and each usb gadget >> can be one usb charger to set the current limitation. >> >> This patch adds a notifier mechanism for usb charger to report to usb >> charger when the usb gadget state is changed. >> >> Also we introduce a callback 'get_charger_type' which will implemented >> by user for usb gadget operations to get the usb charger type. >> >> Signed-off-by: Baolin Wang >> --- >> drivers/usb/gadget/udc/udc-core.c | 41 ++++++++++++++++++++++++++++++++++++- >> include/linux/usb/gadget.h | 20 ++++++++++++++++++ >> 2 files changed, 60 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c >> index f660afb..1971218 100644 >> --- a/drivers/usb/gadget/udc/udc-core.c >> +++ b/drivers/usb/gadget/udc/udc-core.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include > > You just broke the build, which proves you did not properly test this > patch series, so why should we even consider it? > Oh, I'm very sorry about that. I'll re-check my patch and test it carefully. Thanks for your comments. > greg k-h -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/