Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751517AbbHSCg6 (ORCPT ); Tue, 18 Aug 2015 22:36:58 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:34835 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbbHSCg5 (ORCPT ); Tue, 18 Aug 2015 22:36:57 -0400 MIME-Version: 1.0 In-Reply-To: <20150819003217.GQ60523@google.com> References: <20150707072345.GA20060@vaishali-Ideapad-Z570> <20150819003217.GQ60523@google.com> Date: Wed, 19 Aug 2015 08:06:56 +0530 Message-ID: Subject: Re: [PATCH] mtd: denali: Use module_pci_driver From: Vaishali Thakkar To: Brian Norris Cc: David Woodhouse , linux-mtd@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 53 On Wed, Aug 19, 2015 at 6:02 AM, Brian Norris wrote: > > On Tue, Jul 07, 2015 at 12:53:45PM +0530, Vaishali Thakkar wrote: > > Use module_pci_driver for drivers whose init and exit functions > > only register and unregister, respectively. > > > > A simplified version of the Coccinelle semantic patch that performs > > this transformation is as follows: > > > > @a@ > > identifier f, x; > > @@ > > -static f(...) { return pci_register_driver(&x); } > > > > @b depends on a@ > > identifier e, a.x; > > @@ > > -static e(...) { pci_unregister_driver(&x); } > > > > @c depends on a && b@ > > identifier a.f; > > declarer name module_init; > > @@ > > -module_init(f); > > > > @d depends on a && b && c@ > > identifier b.e, a.x; > > declarer name module_exit; > > declarer name module_pci_driver; > > @@ > > -module_exit(e); > > +module_pci_driver(x); > > > > Signed-off-by: Vaishali Thakkar > > It seems I got 3 independent versions of the same patch... I pushed the > most recent one, then noticed this one. Thanks anyway. No problem. It's fine with me. > Brian -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/