Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbbHSGcM (ORCPT ); Wed, 19 Aug 2015 02:32:12 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:36569 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbbHSGcK (ORCPT ); Wed, 19 Aug 2015 02:32:10 -0400 MIME-Version: 1.0 In-Reply-To: <20150818041113.GW26431@google.com> References: <1438039809-24957-1-git-send-email-yinghai@kernel.org> <1438039809-24957-28-git-send-email-yinghai@kernel.org> <20150818041113.GW26431@google.com> Date: Tue, 18 Aug 2015 23:32:09 -0700 X-Google-Sender-Auth: GFB5ZeYy6zriVZ7SAxgSqilVLA4 Message-ID: Subject: Re: [PATCH v3 27/51] PCI: Move ISA ioport align out of calculate_iosize From: Yinghai Lu To: Bjorn Helgaas Cc: David Miller , Benjamin Herrenschmidt , Wei Yang , TJ , Yijing Wang , Andrew Morton , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 30 On Mon, Aug 17, 2015 at 9:11 PM, Bjorn Helgaas wrote: > On Mon, Jul 27, 2015 at 04:29:45PM -0700, Yinghai Lu wrote: >> So we could unify calculate_iosize and calculate_memsize later. > > Please make this a complete sentence, not just a continuation of the > summary line. > >> when one bridge have several children devices, and every devices >> have several io port resources and resource size < 0x400. > > This isn't a sentence either, so I'm not sure what this is supposed to > mean. will change to: Subject: [PATCH] PCI: Move ISA io port align out of calculate_iosize() We can move ISA io port align out of calculate_iosize(), so we could unify calculate_iosize and calculate_memsize later. That extra aligning or offset is to work around ISA devices: When one bridge have several children devices, and every device has several io port resources and resource size < 0x400. We need to check size, and add extra size to make sure bit8/9 to be zero. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/