Date: Wed, 19 Aug 2015 12:01:38 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
        Chris J Arges <chris.j.arges@canonical.com>,
        live-patching@vger.kernel.org
Subject: Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack
 validation
Message-ID: <20150819100138.GA10504@gmail.com>
References: <cover.1439521412.git.jpoimboe@redhat.com>
 <07bf51833b5e1c52bfd9a4dbda41b80c508dffff.1439521412.git.jpoimboe@redhat.com>
 <20150815002354.7fb2f21e.akpm@linux-foundation.org>
 <20150815124913.GB3254@treble.hsd1.ky.comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150815124913.GB3254@treble.hsd1.ky.comcast.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1253
Lines: 39


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Sat, Aug 15, 2015 at 12:23:54AM -0700, Andrew Morton wrote:
> > On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > 
> > > This adds a CONFIG_STACK_VALIDATION option which enables a host tool
> > > named stackvalidate which runs at compile time.
> > 
> > It would be useful to
> > 
> > - show example output for a typical error site
> > 
> > - describe the consequences of that error (ie: why should we fix
> >   these things?)
> > 
> > - describe what needs to be done to repair these sites.
> > 
> > 
> > IOW, what do we gain from merging all this stuff?
> 
> I attempted to do all that in Documentation/stack-validation.txt which
> is in patch 03/20.  Does it address your concerns?  Here it is:

I think it answers the first and third question, but not the second one:

    - describe the consequences of that error (ie: why should we fix
      these things?)

would be nice to document all that richly.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/