Date: Wed, 19 Aug 2015 13:50:22 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte <raphael.beamonte@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org,
        Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
        Greg Donald <gdonald@gmail.com>, linux-kernel@vger.kernel.org,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Joe Perches <joe@perches.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80
 characters code style issue
Message-ID: <20150819105022.GQ5558@mwanda>
References: <cover.1439688440.git.raphael.beamonte@gmail.com>
 <cover.1439880735.git.raphael.beamonte@gmail.com>
 <0fdf9685f3dcb28e2d791376b770f34f0c1be88d.1439880735.git.raphael.beamonte@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0fdf9685f3dcb28e2d791376b770f34f0c1be88d.1439880735.git.raphael.beamonte@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 35

On Tue, Aug 18, 2015 at 12:58:20PM -0400, Rapha?l Beamonte wrote:
> Light code refactoring to keep the lines under 80 characters to follow
> the kernel code style.
> 

The first patches seem fine but this one is too hard to review...
Divide it up somehow.  Maybe:

patch #1: comments
patch #2: add line breaks
patch #3: add temporary variables
patch #4: reverse conditions

I have looked through this patch a little, and I am skepitcal of some
of these changes.  Do they really improve readability?


-                               if (TempCCk == priv->cck_txbbgain_table[i].ccktxbb_valuearray[0]) {
-                                       priv->cck_present_attentuation_20Mdefault = (u8)i;
-                                       break;
-                               }
+                               if (TempCCk !=
+                                   priv->cck_txbbgain_table[i].
+                                               ccktxbb_valuearray[0])
+                                       continue;


regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/