Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbbHSMTu (ORCPT ); Wed, 19 Aug 2015 08:19:50 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:33094 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbbHSMTs (ORCPT ); Wed, 19 Aug 2015 08:19:48 -0400 X-Greylist: delayed 79456 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Aug 2015 08:19:47 EDT MIME-Version: 1.0 In-Reply-To: <1439720057-9186-9-git-send-email-ygardi@codeaurora.org> References: <1439720057-9186-1-git-send-email-ygardi@codeaurora.org> <1439720057-9186-9-git-send-email-ygardi@codeaurora.org> Date: Wed, 19 Aug 2015 21:19:47 +0900 Message-ID: Subject: Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations From: Akinobu Mita To: Yaniv Gardi Cc: Rob Herring , Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 26 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : > @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops ufs_hba_qcom_vops = { > .resume = ufs_qcom_resume, > .dbg_register_dump = ufs_qcom_dump_dbg_regs, > }; > +EXPORT_SYMBOL(ufs_hba_qcom_vops); As I said in the view comment for the patch 5, this shouldn't be exported again. > @@ -775,6 +781,12 @@ static inline int ufshcd_vops_resume(struct ufs_hba *hba, enum ufs_pm_op op) > return 0; > } > > +static inline void ufshcd_vops_dbg_register_dump(struct ufs_hba *hba) > +{ > + if (hba->vops && hba->vops->dbg_register_dump) > + hba->vops->dbg_register_dump(hba); > +} > + This change should be done in the patch 7? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/