Subject: Re: [PATCH v4] tags: much faster, parallel "make tags"
To: Alexey Dobriyan <adobriyan@gmail.com>
References: <20150508132606.GA16613@p183.telecom.by>
 <554D9606.7090908@draigBrady.com> <20150510132633.GA1717@p183.telecom.by>
 <554FC664.8030807@draigBrady.com> <20150511202004.GA7650@p183.telecom.by>
 <20150511202515.GB7650@p183.telecom.by>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
        =?UTF-8?Q?P=c3=a1draig_Brady?= <P@draigBrady.com>
From: Michal Marek <mmarek@suse.cz>
Message-ID: <55D483D4.5020905@suse.cz>
Date: Wed, 19 Aug 2015 15:25:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150511202515.GB7650@p183.telecom.by>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1012
Lines: 34

On 2015-05-11 22:25, Alexey Dobriyan wrote:
> ctags is single-threaded program. Split list of files to be tagged into
> almost equal parts, process them on every CPU and merge the results.

Sorry, I missed the v4 of the patch.


> +	# Remove headers.
> +	for i in .make-tags.t*; do
> +		sed -i -e '/^!/d' $i
> +	done
> +
> +	# Write final header.
> +	$1 -f $2 /dev/null
> +
> +	# Append sorted results.
> +	sort .make-tags.t* >>$2
> +	rm -f .make-tags.t*

This still breaks Exuberant ctags in emacs mode:
$ ln -s /usr/bin/ctags ~/bin/etags
$ make TAGS
  GEN     TAGS
etags: "TAGS" doesn't look like a tag file; I refuse to overwrite it.
etags: "TAGS" doesn't look like a tag file; I refuse to overwrite it.

The TAGS file is corrupted because of the sorting.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/