Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932108AbbHSOZt (ORCPT ); Wed, 19 Aug 2015 10:25:49 -0400 Received: from mx2.parallels.com ([199.115.105.18]:40993 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871AbbHSOZs (ORCPT ); Wed, 19 Aug 2015 10:25:48 -0400 Date: Wed, 19 Aug 2015 17:25:36 +0300 From: Vladimir Davydov To: Jeff Layton CC: Andrew Morton , , Subject: Re: [PATCH] list_lru: don't call list_lru_from_kmem if the list_head is empty Message-ID: <20150819142536.GP21209@esperanza> References: <1439993140-13362-1-git-send-email-jeff.layton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1439993140-13362-1-git-send-email-jeff.layton@primarydata.com> X-ClientProxiedBy: US-EXCH2.sw.swsoft.com (10.255.249.46) To US-EXCH2.sw.swsoft.com (10.255.249.46) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 42 On Wed, Aug 19, 2015 at 10:05:40AM -0400, Jeff Layton wrote: > If the list_head is empty then we'll have called list_lru_from_kmem > for nothing. Move that call inside of the list_empty if block. > > Cc: Vladimir Davydov > Signed-off-by: Jeff Layton Reviewed-by: Vladimir Davydov > --- > mm/list_lru.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/list_lru.c b/mm/list_lru.c > index 909eca2c820e..e1da19fac1b3 100644 > --- a/mm/list_lru.c > +++ b/mm/list_lru.c > @@ -99,8 +99,8 @@ bool list_lru_add(struct list_lru *lru, struct list_head *item) > struct list_lru_one *l; > > spin_lock(&nlru->lock); > - l = list_lru_from_kmem(nlru, item); > if (list_empty(item)) { > + l = list_lru_from_kmem(nlru, item); > list_add_tail(item, &l->list); > l->nr_items++; > spin_unlock(&nlru->lock); > @@ -118,8 +118,8 @@ bool list_lru_del(struct list_lru *lru, struct list_head *item) > struct list_lru_one *l; > > spin_lock(&nlru->lock); > - l = list_lru_from_kmem(nlru, item); > if (!list_empty(item)) { > + l = list_lru_from_kmem(nlru, item); > list_del_init(item); > l->nr_items--; > spin_unlock(&nlru->lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/