Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbbHSOa7 (ORCPT ); Wed, 19 Aug 2015 10:30:59 -0400 Received: from exsmtp03.microchip.com ([198.175.253.49]:60893 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932191AbbHSOa6 (ORCPT ); Wed, 19 Aug 2015 10:30:58 -0400 Date: Wed, 19 Aug 2015 16:30:48 +0200 From: Christian Gromm To: Adrian Remonda CC: , , Subject: Re: [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Message-ID: <20150819163048.4a8082bf@muaddib> In-Reply-To: <1439547484-20492-3-git-send-email-adrianremonda@gmail.com> References: <1439547484-20492-1-git-send-email-adrianremonda@gmail.com> <1439547484-20492-3-git-send-email-adrianremonda@gmail.com> Organization: MCHP X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 31 On Fri, 14 Aug 2015 12:18:01 +0200 Adrian Remonda wrote: > This patch fixes the warning generated by sparse: "Using plain integer > as NULL pointer" by replacing the pointer test against 0 with a logical test. > > Signed-off-by: Adrian Remonda Acked-by: Christian Gromm > --- > drivers/staging/most/mostcore/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c > index fa9c19b65a5c..7bb16db42893 100644 > --- a/drivers/staging/most/mostcore/core.c > +++ b/drivers/staging/most/mostcore/core.c > @@ -982,7 +982,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj, > if (ret) > return ret; > > - if (mdev_devnod == 0 || *mdev_devnod == 0) { > + if (!mdev_devnod || *mdev_devnod == 0) { > snprintf(devnod_buf, sizeof(devnod_buf), "%s-%s", mdev, mdev_ch); > mdev_devnod = devnod_buf; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/