Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752551AbbHSQgQ (ORCPT ); Wed, 19 Aug 2015 12:36:16 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:4813 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbbHSQgP (ORCPT ); Wed, 19 Aug 2015 12:36:15 -0400 Date: Wed, 19 Aug 2015 09:35:48 -0700 From: Bjorn Andersson To: Mathieu Olivari CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "agross@codeaurora.org" , "sboyd@codeaurora.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH v4 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts Message-ID: <20150819163548.GX13472@usrtlx11787.corpusers.net> References: <1439931860-7473-1-git-send-email-mathieu@codeaurora.org> <1439931860-7473-2-git-send-email-mathieu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1439931860-7473-2-git-send-email-mathieu@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 44 On Tue 18 Aug 14:04 PDT 2015, Mathieu Olivari wrote: > Add one new node to the ipq806x.dtsi file to declare & register the > hardware spinlock devices. This mechanism is required to be used by > other drivers such as SMEM. > Still looks good, but you should have added: Reviewed-by: Bjorn Andersson > Signed-off-by: Mathieu Olivari > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 9f727d8..8d366ae 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -329,5 +329,16 @@ > #reset-cells = <1>; > }; > > + sfpb_mutex_block: syscon@1200600 { > + compatible = "syscon"; > + reg = <0x01200600 0x100>; > + }; > + }; > + > + sfpb_mutex: sfpb-mutex { > + compatible = "qcom,sfpb-mutex"; > + syscon = <&sfpb_mutex_block 4 4>; > + > + #hwlock-cells = <1>; > }; > }; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/