Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbbHSVDk (ORCPT ); Wed, 19 Aug 2015 17:03:40 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:41941 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbHSVDi (ORCPT ); Wed, 19 Aug 2015 17:03:38 -0400 Date: Wed, 19 Aug 2015 23:03:30 +0200 From: Ralf Baechle To: Hauke Mehrtens Cc: Alban Bedel , linux-mips@linux-mips.org, Andrew Bresticker , Qais Yousef , Wolfram Sang , Sergey Ryazanov , Gabor Juhos , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API Message-ID: <20150819210330.GO3612@linux-mips.org> References: <1429446604-15403-1-git-send-email-albeu@free.fr> <1429446604-15403-6-git-send-email-albeu@free.fr> <55C745B7.3040002@hauke-m.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C745B7.3040002@hauke-m.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 41 On Sun, Aug 09, 2015 at 02:21:11PM +0200, Hauke Mehrtens wrote: > Date: Sun, 09 Aug 2015 14:21:11 +0200 > From: Hauke Mehrtens > To: Alban Bedel , linux-mips@linux-mips.org, Ralf Baechle > > CC: Andrew Bresticker , Qais Yousef > , Wolfram Sang , Sergey > Ryazanov , Gabor Juhos , > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API > Content-Type: text/plain; charset=windows-1252 > > On 04/19/2015 02:30 PM, Alban Bedel wrote: > > Make the code simpler and open the way for device tree clocks. > > > > Signed-off-by: Alban Bedel > > --- > > arch/mips/Kconfig | 1 + > > arch/mips/ath79/clock.c | 29 ++--------------------------- > > 2 files changed, 3 insertions(+), 27 deletions(-) > > > > I think this should be send at least to stable 4.1, because it fixes a > linking problem we are seeing in OpenWrt. > > ath79 does not export clk_set_rate() and clk_round_rate(), but some > drivers are using it and they are not using the inline dummy method, > because CONFIG_HAVE_CLK is set for ath79. > > ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined! > ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined! > ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined! Ok. Will post the the patch in a separate email. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/