Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbbHSVY5 (ORCPT ); Wed, 19 Aug 2015 17:24:57 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:34073 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752362AbbHSVYz convert rfc822-to-8bit (ORCPT ); Wed, 19 Aug 2015 17:24:55 -0400 MIME-Version: 1.0 In-Reply-To: <1439941188-19293-10-git-send-email-joestringer@nicira.com> References: <1439941188-19293-1-git-send-email-joestringer@nicira.com> <1439941188-19293-10-git-send-email-joestringer@nicira.com> Date: Wed, 19 Aug 2015 14:24:54 -0700 Message-ID: Subject: Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label From: Pravin Shelar To: Joe Stringer Cc: netdev , LKML , pablo , Florian Westphal , Hannes Sowa , Thomas Graf , Justin Pettit , Jesse Gross Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2799 Lines: 67 On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Allow matching and setting the conntrack label field. As with ct_mark, > this is populated by executing the CT action, and is a writable field. > Specifying a label and optional mask allows the label to be modified, > which takes effect on the entry found by the lookup of the CT action. > > E.g.: actions:ct(zone=1,label=1) > > This will perform conntrack lookup in zone 1, then modify the label for > that entry. The conntrack entry itself must be committed using the > "commit" flag in the conntrack action flags for this change to persist. > > Signed-off-by: Joe Stringer I got compilation error after applying this patch: net/openvswitch/conntrack.c: In function ‘ovs_ct_init’: net/openvswitch/conntrack.c:713: error: expected ‘)’ before ‘;’ token net/openvswitch/conntrack.c:715: error: expected expression before ‘}’ token > --- > v2: Split out setting the connlabel size for the current namespace. > v3: No change. > v4: Only allow setting label via ct action. > Update documentation. > --- ... > type); > @@ -432,6 +521,10 @@ bool ovs_ct_verify(enum ovs_key_attr attr) > if (attr & OVS_KEY_ATTR_CT_MARK) > return true; > #endif > +#ifdef CONFIG_NF_CONNTRACK_LABELS > + if (attr & OVS_KEY_ATTR_CT_LABEL) > + return true; > +#endif > OVS_KEY_ATTR_CT_LABEL is not bit field so bitwise AND operation does not work here. This applies to all check done in this function. > return false; > } > @@ -508,8 +601,12 @@ void ovs_ct_free_action(const struct nlattr *a) > > void ovs_ct_init(struct net *net, struct ovs_ct_perdp_data *data) > { > + unsigned int n_bits = sizeof(struct ovs_key_ct_label) * BITS_PER_BYTE; > + > data->xt_v4 = !nf_ct_l3proto_try_module_get(PF_INET); > data->xt_v6 = !nf_ct_l3proto_try_module_get(PF_INET6); > + if (nf_connlabels_get(net, n_bits); > + OVS_NLERR(true, "Failed to set connlabel length"); > } > In case of error should we reject conntrack label actions? Otherwise user will never see any error. But action could drop packets. > void ovs_ct_exit(struct net *net, struct ovs_ct_perdp_data *data) > @@ -518,4 +615,5 @@ void ovs_ct_exit(struct net *net, struct ovs_ct_perdp_data *data) > nf_ct_l3proto_module_put(PF_INET); > if (data->xt_v6) > nf_ct_l3proto_module_put(PF_INET6); > + nf_connlabels_put(net); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/