Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbHSXOS (ORCPT ); Wed, 19 Aug 2015 19:14:18 -0400 Received: from ozlabs.org ([103.22.144.67]:50713 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbbHSXOQ (ORCPT ); Wed, 19 Aug 2015 19:14:16 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 1d805440a364b4a68562e70119d8f94456698e55 In-Reply-To: <1435815541-11860-1-git-send-email-nikunj@linux.vnet.ibm.com> To: Nikunj A Dadhania , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: anton@samba.org, linux-kernel@vger.kernel.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com Subject: Re: [RESEND] powerpc/numa: initialize distance lookup table from drconf path Message-Id: <20150819231414.BF91C140771@ozlabs.org> Date: Thu, 20 Aug 2015 09:14:14 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 48 On Thu, 2015-02-07 at 05:39:01 UTC, Nikunj A Dadhania wrote: > In some situations, a NUMA guest that supports > ibm,dynamic-memory-reconfiguration node will end up having flat NUMA > distances between nodes. This is because of two problems in the > current code. > > 1) Different representations of associativity lists. > > There is an assumption about the associativity list in > initialize_distance_lookup_table(). Associativity list has two forms: > > a) [cpu,memory]@x/ibm,associativity has following > format: > > > b) ibm,dynamic-reconfiguration-memory/ibm,associativity-lookup-arrays > > > M = the number of associativity lists > N = the number of entries per associativity list > > Fix initialize_distance_lookup_table() so that it does not assume > "case a". And update the caller to skip the length field before > sending the associativity list. > > 2) Distance table not getting updated from drconf path. > > Node distance table will not get initialized in certain cases as > ibm,dynamic-reconfiguration-memory path does not initialize the > lookup table. > > Call initialize_distance_lookup_table() from drconf path with > appropriate associativity list. > > Reported-by: Bharata B Rao > Signed-off-by: Nikunj A Dadhania > Acked-by: Anton Blanchard Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1d805440a364b4a68562 cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/