Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbbHTAYh (ORCPT ); Wed, 19 Aug 2015 20:24:37 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:42562 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbbHTAYg (ORCPT ); Wed, 19 Aug 2015 20:24:36 -0400 X-IronPort-AV: E=Sophos;i="5.15,713,1432598400"; d="scan'208";a="296131491" Message-ID: <55D51E1B.8090701@citrix.com> Date: Wed, 19 Aug 2015 17:23:55 -0700 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Murilo Opsfelder Araujo , , CC: Konrad Rzeszutek Wilk , Boris Ostrovsky , Stefano Stabellini , David Vrabel Subject: Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() References: <1439990719-19517-1-git-send-email-mopsfelder@gmail.com> In-Reply-To: <1439990719-19517-1-git-send-email-mopsfelder@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 33 Hi, On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote: > The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use > xen_page_to_gfn rather than pfn_to_gfn" left behind a call to > xen_tmem_get_page() receiving pfn instead of page. > > This change also fixes the following build warning: > > drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’: > drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast > ret = xen_tmem_get_page((u32)pool, oid, ind, pfn); > ^ > drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’ > static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid, > ^ > > Signed-off-by: Murilo Opsfelder Araujo Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not enabled on my config. Reviewed-by: Julien Grall Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/