Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbbHTFeg (ORCPT ); Thu, 20 Aug 2015 01:34:36 -0400 Received: from ozlabs.org ([103.22.144.67]:39322 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbbHTFef (ORCPT ); Thu, 20 Aug 2015 01:34:35 -0400 From: Rusty Russell To: Peter Zijlstra Cc: Laura Abbott , "Paul E. McKenney" , Linux Kernel Mailing List Subject: Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr? In-Reply-To: <20150819124204.GP10304@worktop.programming.kicks-ass.net> References: <55D26C29.5040204@redhat.com> <20150818023137.GI20948@worktop> <87lhd8uxso.fsf@rustcorp.com.au> <20150819124204.GP10304@worktop.programming.kicks-ass.net> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 20 Aug 2015 10:40:55 +0930 Message-ID: <87mvxmkbmo.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 22 Peter Zijlstra writes: > On Wed, Aug 19, 2015 at 06:19:43AM +0930, Rusty Russell wrote: >> Indeed! That comment is wrong, and your fix is good. >> >> Care to S-O-B on it? > > Of course, here goes. Thanks! This is an ancient bug (2009) which your extra assertions caught. It's unlikely to have ever bitten anyone, but I've CC'd stable for it anyway: Fixes: a6e6abd575fc ("module: remove module_text_address()") Cc: stable@kernel.org Applied, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/