Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbbHTFFZ (ORCPT ); Thu, 20 Aug 2015 01:05:25 -0400 Received: from mail-db3on0074.outbound.protection.outlook.com ([157.55.234.74]:30892 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750879AbbHTFFW (ORCPT ); Thu, 20 Aug 2015 01:05:22 -0400 Authentication-Results: spf=fail (sender IP is 212.179.42.66) smtp.mailfrom=ezchip.com; synopsys.com; dkim=none (message not signed) header.d=none; From: Noam Camus To: , CC: , , , , Noam Camus Subject: [v2 0/5] *** nps_enet fixups *** Date: Thu, 20 Aug 2015 08:00:00 +0300 Message-ID: <1440046805-24459-1-git-send-email-noamc@ezchip.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <20150817.103607.1737876155019074073.davem@davemloft.net> References: <20150817.103607.1737876155019074073.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-21758.005 X-TM-AS-Result: No--2.318100-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD041;1:ZyajVf4p6DH1IOVVFh4B82AWn7M3E5OD/holG77s8zWsZTl9jrZ393LGMMxjToBtsqPJi4HHMWQrcuASE4OiIe0JAZ8IcIu6fI103X15HAn37lEv7eQGgIoTTqEr4+BSkla1+CyKb/MzMUjQ5hJqGB4wsv62qyjXlJ2etChNBpC3P43AvPyK8PxvGHlzWmW49F+kaMHmoxxW4s/vyGsShmUf80Rkw4YfpsPeZBbPMslkxNkTbKKI1yha/D+EEDpb49lZbaevxoYGM2gQooHHGYWBDNQQZZ6X7mnQbAnU+NVlfPEQPi1LKQPbL9butDESR3HNXPyd9FBnLYTajhQiaTUYA8oUtyhIi5gEwoAAwfeac+rfJRI7Ua9tQupU3V91 X-Forefront-Antispam-Report: CIP:212.179.42.66;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(3050300001)(339900001)(199003)(189002)(19580395003)(33646002)(5003940100001)(86362001)(5001770100001)(47776003)(64706001)(4001540100001)(106466001)(92566002)(5001970100001)(105606002)(5001860100001)(5001830100001)(189998001)(107886002)(229853001)(50466002)(62966003)(36756003)(104016003)(46102003)(48376002)(19580405001)(85426001)(49486002)(50986999)(6806004)(50226001)(77096005)(77156002)(76176999)(2950100001)(87936001)(5007970100001)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR02MB1039;H:ezex10.ezchip.com;FPR:;SPF:Fail;PTR:ezmail.ezchip.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1039;2:Te/nwQCCeuV+iPFGpYZnthkvwey4kZ2GvqxCnKFXHj/8cloKd+uk3asMZRcIRUPQ5rLpLAPcvDViRJja4XMgurrM8NO7F5BgXV01s7B8KWsW0E//E548pmIlo24JqCJTNgoMBAS5memmV+bit4zPODOOaidrsZNI1ZxZl1RJ9uM=;3:jQGtn3+dzC7pAhtnag5gonjcLblu9mb1SpXgqrTsYeeRv5DBKR5BKNBRQB+E7eRjFIAwID43fIDNE0kUFbLHfkXqEBOPu4GXtJNlevsTvtqHKLAEOK14FzOC5G+DlhQ4AFUPC7eV7p+u0qJhloi0xWWzyx4Ad6AMJMVJAHHESRWgEB2xOQhQ/konw2TfkgSI2ujE2f/7/7ukBevu/0N/3tN27ZVMoCw/ulB7IOJVxns=;25:OK1jhbeZJ3NhXUt2mpcMJSW1F/iH2GIGpHDQdZu1mHhdX6D0+JQN5/uLyZKOidnJMmOz1EpvSxjO6T6rU0d27ZXB1EethL0QYMhCtWbNtxWUlZNe4XJxJcE+pTlHEQoSzNArXNZx9drjdaJ3btoNw4zHVEDgK399ACqzDWPAeTB01lYs/jN8LK3QgGcOAyAea2Rlgm5ODQ2Shz2UwrdD4pYHG1sqj1FZ4w6lxmNhlayF7ukr6fMFeaNvCUjBY8+AxNew9MXZ3rywfz8EusUWBg==;20:aSEFRhCvfbU9HW9t97f/sIaQdD9A9NeeIbqHveO2m3m4EntQfWnMWFhWgNRi6PS71UnK0jlaxx60B3pbsx7MAs8ZhcHCfz7rTlcdKWiAHHmHh9vBqiIcoE1Hc2uhg/++Go7eDL36l+Cd2EnmDYx5IKW4P/rxa8LpOefspD3YKqs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB1039; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:VI1PR02MB1039;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB1039; X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1039;4:mvg9BtDVj2+U1RM1in2OOaIB0SO+qpBInodvR0Tgevty47DhjlJdIEm89tehN4qsQoFIedfXmagheqzP0yTLsiEhHfjEo3ZpUgNTSuu91+hGgWi4l8qQGnenLps+Zy7oJKhDvIwRWf0dPvDwO5botcM5tw1cBDa0MEuNR7FKvc8Jm2xfPYT2js8LaKCFM+KT5NmwZWcqf4cpPeN98muvYWxOLSAg2kBo6TbrnVsaI7ybMq2ryU7qPPj/OGThNsaUPbmQkcATdPmYGo1K6V+FHNLxewf4c4PP0qcM/OwI9XcWMbGjyy2jJLvEACxH8trd X-Forefront-PRVS: 0674DC6DD3 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR02MB1039;23:x1jFs5nUQ0kwxY+pZ2DRLT9xuDpRWCdSMXawxKCWI?= =?us-ascii?Q?Wa4kLGJdJb1yeh3j7slH4oTuhXqpERdwPLjmU2J8Oq8KwVMy66ipQW4FLlRG?= =?us-ascii?Q?yw8yOZbe11g51cn7tCeptFstro3qD3Jkg0Ezo3qwO+Xn4fPwCEGtKGyhmKWW?= =?us-ascii?Q?1p0oJhAmWwsnUKuSrACOdZP873EtyfYyL9OBCzoAOYxfLtxGUFv/DAZ6ROXi?= =?us-ascii?Q?nxnod7g5VcNNsCTVaRZKxY1c1b01q7iyJpoPEhVp5OnKldXM0re4vSqp7sjk?= =?us-ascii?Q?arYrXomp1+tUXq3WwpgXLlJ4O+ZCTfAxVyYcWpZ1MMRBGGZ7nnR6xljAV8GU?= =?us-ascii?Q?+OCicDcDEqYiphRmKOQcwyRnpKne9XUj56NEbaxWRiYm7qSvPRO3myfiTcrz?= =?us-ascii?Q?jqliguLDIkaJBCJnpXwzmClQnyiB7bkg7UZLLSNnTh7NmfJphqMnGzxVvYgs?= =?us-ascii?Q?1WQsxHP1MiLTW5hncYSh2y/iA7TeP7QIWBdnQZDW0geRegqbxMLDRFQqSu75?= =?us-ascii?Q?XLcj34Llo1ES5yj2UpiGJC0Rw1e23Z2WrMJHjke+DFKPMP840lmSxAA0U+nP?= =?us-ascii?Q?wqDFVlGpqs3GSCgWuhirR0CM871OW8Z+SS2TijmCze4FXZkJh+WhlZHD8nGH?= =?us-ascii?Q?h+a84pbIl9IkkfJYbrTd86PuHuR5N9OkWb7NoyUz7+Hjp4y8w8HU7H8/5Rrj?= =?us-ascii?Q?7+eqMtMUpqasAxHRdE8kMNklPm2QQbq8giqbNDJYkTEVr3nq8prR6pKBK7Dl?= =?us-ascii?Q?o98O3kEOHqwS66MJ1DD9ciYQqdkZCyyGdOz50sVP2Mbv3EeqnnreEL7TvJSA?= =?us-ascii?Q?OJIypYOJZje7p/SKjyFruIVwSmNQp9jgnWRoWxpEjKqFzQgu0KkGn5YPd6Fy?= =?us-ascii?Q?XW/5Tg9RhzHUxwBfcaNlwriofnPb2wVpS5OJjmMBldlODdSDKklLVg5/PKVA?= =?us-ascii?Q?DA9aCr/TRm8zFmzSu3DIEldef6AH0YzYO9ftZZHTh2rvxYI865bJqGZfcB1i?= =?us-ascii?Q?+e16fVJqDe9VkH/IxCEW44cLya9omfqkSHplOOGeGwpoVPM6JRQtgMo6sQjX?= =?us-ascii?Q?8RS7Hyl26oAliqD12Vn1+pvUVk32BvOntlfb+7hcbEH3RqlzdOlgHgfJgv2q?= =?us-ascii?Q?0VT6ICIMihNMDUfVQOq6EjJaCqVCt35x53FonK9+ZAGzbN91gy4SA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1039;5:y9WD3qBnUAEgxfCCqQ0kXHx9XhEAVMdPLi/3VixitE+PbtPks/dZtxXG8k17MvFgvNbEaCni8zBDvQGGeKUSf5mWd80eMumCxb1GqevdSpXLzVm14DAmyyU/FkifIwb+N0JxVJJ1giBzHHLXyh1ErQ==;24:yGlUpTzeWpm9faf77H1w8NpGyt0i2UYSiuI0/O9GvzeTpdXsMMi53C0ecJrHP9slm/NYmSBCNJzmQN2NEZusgmq5GzP6YZwOPBbHxMNou+U=;20:v5MYqwB/058LLLdBL8JBL1lh4TrdcXtLJu47ZECFLyD2JzSfrQfNBtpNPGWO799UGKSMey3fCGWZP96ihiroUQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2015 05:05:18.4191 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[212.179.42.66];Helo=[ezex10.ezchip.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB1039 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 35 From: Noam Camus Change v2 TX done is handled back with NAPI poll. Change v1 This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the TX end interrupt is "edge-sensitive" and therefore we cannot use the cause register since it is not sticky. Also: TX is handled during HW interrupt context and not NAPI job. race with TX done was fixed. added acknowledge for TX when device is "level sensitive". enable drop of control frames which is not needed for regular usage. So most of this patch set is about TX handling, which is now more complete. Noam Camus (5): NET: nps_enet: replace use of cause register NET: nps_enet: TX done race condition NET: nps_enet: drop control frames NET: nps_enet: TX done acknowledge. NET: nps_enet: minor namespace cleanup drivers/net/ethernet/ezchip/nps_enet.c | 37 ++++++++++++++++--------------- drivers/net/ethernet/ezchip/nps_enet.h | 20 ----------------- 2 files changed, 19 insertions(+), 38 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/