Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbbHTFid (ORCPT ); Thu, 20 Aug 2015 01:38:33 -0400 Received: from mga14.intel.com ([192.55.52.115]:25196 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbHTFib (ORCPT ); Thu, 20 Aug 2015 01:38:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,713,1432623600"; d="scan'208";a="787283167" Date: Thu, 20 Aug 2015 11:10:34 +0530 From: Vinod Koul To: Rameshwar Prasad Sahu Cc: dan.j.williams@intel.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com Subject: Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine Message-ID: <20150820054034.GX13546@localhost> References: <1438258268-3099-1-git-send-email-rsahu@apm.com> <1438258268-3099-3-git-send-email-rsahu@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438258268-3099-3-git-send-email-rsahu@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 43 On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote: > + /* Invalidate unused source address field */ > + for (; i < 4; i++) > + xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i)); > + > + /* Check whether requested buffer processed */ > + if (nbytes) { > + chan_err(chan, "Src count crossed maximum limit\n"); > + return -EINVAL; no cleanup ? > +struct dma_async_tx_descriptor *xgene_dma_prep_flyby( > + struct xgene_dma_chan *chan, struct scatterlist *src_sg, > + size_t len, u32 seed, u8 *result, unsigned long flags, u8 opcode) please fix style here > +struct dma_async_tx_descriptor *xgene_dma_prep_crc32c( > + struct dma_chan *dchan, struct scatterlist *src_sg, > + size_t len, u32 seed, u8 *result, unsigned long flags) here too > @@ -1309,8 +1512,13 @@ static void xgene_dma_setup_ring(struct xgene_dma_ring *ring) > ring->pdma->csr_ring + XGENE_DMA_RING_ID); > > /* Set DMA ring buffer */ > - iowrite32(XGENE_DMA_RING_ID_BUF_SETUP(ring->num), > - ring->pdma->csr_ring + XGENE_DMA_RING_ID_BUF); > + ring_id_buf = XGENE_DMA_RING_ID_BUF_SETUP(ring->num); > + > + if (ring->is_bufpool) > + ring_id_buf |= XGENE_DMA_RING_IS_BUFPOOL; > + > + iowrite32(ring_id_buf, ring->pdma->csr_ring + > + XGENE_DMA_RING_ID_BUF); pls fix style here -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/