Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750986AbbHTGLq (ORCPT ); Thu, 20 Aug 2015 02:11:46 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34326 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbbHTGLh convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 02:11:37 -0400 References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <1439995929-18719-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 (1.0) In-Reply-To: <1439995929-18719-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Message-Id: Cc: Heiko Stuebner , Thierry Reding , Fabio Estevam , Inki Dae , "joe@perches.com" , Russell King , "djkurtz@google.com" , "dianders@google.com" , "seanpaul@google.com" , Takashi Iwai , "ajaynumb@gmail.com" , Andrzej Hajda , Kyungmin Park , Philipp Zabel , David Airlie , Gustavo Padovan , Vincent Palatin , Mark Yao , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , jingoohan1@gmail.com X-Mailer: iPhone Mail (11D257) From: Jingoo Han Subject: Re: [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect Date: Thu, 20 Aug 2015 15:11:29 +0900 To: Yakir Yang Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1909 Lines: 51 On 2015. 8. 19., at PM 11:52, Yakir Yang wrote: > > Some edp screen with no hpd signal would need some delay time > to ensure that screen would be ready for work, so we can expand > the delay time in hpd detect function, it works prefectly on my > rk3288 sdk board. Then, this delay has a dependency on the "rk3288 sdk" board. Also, if the delay time is expanded, the booting time of some Exybos boards will be increased unnecessarily. :-( So, please add new DT property such as 'hpd-delay' that can be added to board DT files. If there is not that DT property in DT files, the default value '10' will written to a variable such as 'unsigned int hpd_delay'. If there is the DT property in DT files, the delay value will written to the variable when parsing DT values and will be used in analogix_dp_detect_hpd(). What I want to say is that there should not be harmful effect on the existing Exynos boards, due to unrelated reasons. Best regards, Jingoo Han > Signed-off-by: Yakir Yang > --- > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix_dp_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix_dp_core.c > index 99870f7..75dd44a 100644 > --- a/drivers/gpu/drm/bridge/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c > @@ -68,7 +68,7 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp) > return 0; > > timeout_loop++; > - usleep_range(10, 11); > + usleep_range(100, 110); > } > > /* > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/