Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbbHTGSw (ORCPT ); Thu, 20 Aug 2015 02:18:52 -0400 Received: from ozlabs.org ([103.22.144.67]:38222 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbbHTGSv convert rfc822-to-8bit (ORCPT ); Thu, 20 Aug 2015 02:18:51 -0400 Date: Thu, 20 Aug 2015 16:18:49 +1000 From: Stephen Rothwell To: Bjorn Helgaas Cc: Tadeusz Struk , Randy Dunlap , linux-next list , "linux-kernel@vger.kernel.org" , linux-pci , Herbert Xu , Michal Marek , "Yann E. MORIN" , linux-kbuild Subject: Re: linux-next: Tree for Aug 12 (include/linux/pci.h) Message-ID: <20150820161849.79552437@canb.auug.org.au> In-Reply-To: References: <20150812233914.451d1fcf@canb.auug.org.au> <55CB8AF0.4060905@infradead.org> <20150813075322.064035f8@canb.auug.org.au> <55CBCF96.7060102@intel.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2049 Lines: 62 Hi Bjorn, On Wed, 19 Aug 2015 23:16:06 -0700 Bjorn Helgaas wrote: > > [+cc Yann, linux-kbuild] > > On Wed, Aug 12, 2015 at 3:58 PM, Tadeusz Struk wrote: > > On 08/12/2015 02:53 PM, Stephen Rothwell wrote: > >> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap wrote: > >>> > > >>> > on i386 or x86_64: > >>> > > >>> > Many (repeated) errors like this one: > >>> > > >>> > ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’ > >>> > > >>> > when CONFIG_PCI_ATS is not enabled. > >> Maybe caused by commit > >> > >> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver") > >> > >> from the crypto tree Which adds a > >> > >> select PCI_IOV > >> > >> to drivers/crypto/qat/Kconfig without the necessary > >> > >> select PCI > >> > >> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am > >> assuming that your config has PCI_IOV enabled? What about PCI? > > > > There is a patch submitted, but not yet applied > > https://patchwork.kernel.org/patch/6994171/ > > maybe it will help? > > I don't understand this. In drivers/pci/Kconfig, we have: > > config PCI_IOV > depends on PCI > > and in drivers/crypto/qat/Kconfig, dd0f368398ea adds: > > config CRYPTO_DEV_QAT_DH895xCCVF > select PCI_IOV > > And apparently it's possible to end up with a .config with > CONFIG_PCI_IOV=y but CONFIG_PCI is not set? That seems wrong, since > we declared that PCI_IOV depends on PCI. Does select ignore that > dependency somehow? Yeah, unfortunately that is how select works. If a symbol you select depends on anything, then you need to also select all the dependencies. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/