Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbbHTGpn (ORCPT ); Thu, 20 Aug 2015 02:45:43 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbbHTGpm (ORCPT ); Thu, 20 Aug 2015 02:45:42 -0400 Subject: Re: [PATCH 1/2] ubifs: Remove dead xattr code To: Dongsheng Yang , linux-mtd@lists.infradead.org References: <1440016553-26481-1-git-send-email-richard@nod.at> <55D54006.9030700@cn.fujitsu.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Subodh Nijsure , Marc Kleine-Budde , Brad Mouring , Gratian Crisan , Artem Bityutskiy , Artem Bityutskiy From: Richard Weinberger Message-ID: <55D57791.4000302@nod.at> Date: Thu, 20 Aug 2015 08:45:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55D54006.9030700@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 32 Am 20.08.2015 um 04:48 schrieb Dongsheng Yang: > On 08/20/2015 04:35 AM, Richard Weinberger wrote: >> This is a partial revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53 >> ("UBIFS: Add security.* XATTR support for the UBIFS"). > > Hi Richard, > What about a full reverting of this commit. In ubifs, we > *can* support any namespace of xattr including user, trusted, security > or other anyone prefixed by any words. But we have a check_namespace() > in xattr.c to limit what we want to support. That said, if we want to > "Add security.* XATTR support for the UBIFS", what we need to do is > just extending the check_namespace() to allow security namespace pass. > And yes, check_namespace() have been supporting security namespace. You're right. I thought/hoped we can re-use some parts of it. Se let's do a full revert. I'll send a v2 patch in a jiffy. > So, IMHO, we do not depend on the generic mechanism at all, and we can > fully revert this commit. > > But strange to me, why we picked this commit for ubifs? Artem, is there > something I am missing? TBH, I fear nobody noticed. :( Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/